Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expires_at #58

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
4 participants
@DenisCarriere
Copy link
Collaborator

commented Jun 11, 2019

  • remove expires_at parameter in propose ACTION
  • removed extend, expire & clnproposal ACTION
  • remove expires_at checks
  • remove max_count from cancel ACTION

To prevent maximum CPU limit errors, only 1500 votes can be removed per cancel action

Testing

Contract deployed on https://bos-test.eosx.io/tools/contract?contractAccount=eosforumdapp

Remove expires_at
remove expires_at parameter in propose ACTION, and no need extend ACTION for our new version

@DenisCarriere DenisCarriere requested review from kesar and libhasheos Jun 11, 2019

@DenisCarriere DenisCarriere self-assigned this Jun 11, 2019

@DenisCarriere DenisCarriere added this to In progress in Contracts via automation Jun 11, 2019

@Thaipanda Thaipanda self-requested a review Jun 11, 2019

Contracts automation moved this from In progress to Reviewer approved Jun 11, 2019

@Thaipanda Thaipanda merged commit 4dc3342 into master Jun 11, 2019

Contracts automation moved this from Reviewer approved to Done Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.