bosun: Ability to throttle log notifications #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -174,6 +174,13 @@ func (s *Schedule) RunHistory(r *RunHistory) { | |||
| // If the old alert was not acknowledged, do nothing. | |||
| // Do nothing if state did not change. | |||
| notify := func(ns *conf.Notifications) { | |||
| if a.Log { | |||
| lastLogTime, ok := s.lastLogTimes[ak] | |||
| if ok && lastLogTime.Add(a.MaxLogFrequency).After(time.Now()) { | |||
There was a problem hiding this comment.
how about set now := time.Now() to avoid calling it twice?
There was a problem hiding this comment.
Shouldn't that be .Before?
There was a problem hiding this comment.
LastTime + 5m is next time we can log.
If now is before that we should not log. I think mine is correct but I agree it would make more sense to do now.Before(last + duration)
There was a problem hiding this comment.
You're right. I was confused. No need to change unless you feel strongly.
|
LGTM |
maddyblue
added a commit
that referenced
this pull request
Jun 5, 2015
bosun: Ability to throttle log notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
maxLogFrequencykey to alerts that can control how often notification gets run. Only valid on log alerts.Fixes #975