cmd/bosun: clear filters when changing metrics in graph view #1685

Merged
merged 1 commit into from Mar 30, 2016

Projects

None yet

1 participant

@kylebrandt
Member

Fixes #1679, Creates #??

@kylebrandt kylebrandt cmd/bosun: clear filters when changing metrics in graph view
Fixes #1679, Creates #??
5b6a513
@kylebrandt
Member

Need to test this more before merging. This code is really messy at this point. There is probably repeated operations on tags and filters that don't need to be there. Once OpenTSDB is at v2.3 we can remove support for v2.1 and at that time I think it will be easier to redo this code.

@kylebrandt
Member

There is still an edge case here where if you switch metrics, the two metrics share a tag key, but the value set for that tag is not present in the new metric it will still be there.

However, in that case this isn't hidden and you can just change the value, so I don't care to fix this at this point.

@kylebrandt kylebrandt merged commit 5b6a513 into master Mar 30, 2016

2 checks passed

bosun All checks Passed!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kylebrandt kylebrandt deleted the fixGraph branch Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment