cmd/bosun: stopping notifications that should no longer fire #1716

Merged
merged 3 commits into from May 6, 2016

Projects

None yet

2 participants

@captncraig
Contributor

Fixes #1690

captncraig added some commits Apr 19, 2016
@captncraig captncraig stopping notifications that should no longer fire.
cf484f1
@captncraig captncraig don;t apply that logic to log alerts
a26dfa7
@kylebrandt kylebrandt commented on an outdated diff Apr 28, 2016
cmd/bosun/sched/notify.go
@@ -121,7 +125,11 @@ func (s *Schedule) sendNotifications(silenced SilenceTester) {
}
s.pendingUnknowns[n] = append(s.pendingUnknowns[n], st)
} else if silenced {
- slog.Infoln("silencing", ak)
+ slog.Infof("silencing %s", ak)
+ continue
+ } else if !alert.Log && (!st.Open || !st.NeedAck) {
+ slog.Infof("Cannot notify acked or closed alert %s", ak)
@kylebrandt
kylebrandt Apr 28, 2016 Member

Can we log more info about the alert / notification here so we might be able to find when they are in the queue when they shouldn't be?

@captncraig captncraig Clearing notifications on all actions, not just ack.
9036bcf
@captncraig captncraig merged commit 2a899e7 into master May 6, 2016

2 checks passed

bosun All checks Passed!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kylebrandt kylebrandt deleted the stopNotifications branch Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment