collect: creating buffer pool for sending datapoints #1838

Merged
merged 1 commit into from Jul 27, 2016

Conversation

Projects
None yet
2 participants
@captncraig
Contributor

captncraig commented Jul 27, 2016

This is a minor optimization that should reduce gc pressure in the collect package.

Tested with a simple app that sends batches of 300 data points to a local black hole server every 30ms. Monitored with expvarmon

super unscientific data:

Before:
screen shot 2016-07-27 at 12 10 22 am

After:
screen shot 2016-07-27 at 12 12 27 am

Notice difference in HeapAlloc and Alloc. gc time is pretty much negligible at this scale, but its always good to throw away less stuff.

@gbrayut

This comment has been minimized.

Show comment
Hide comment
@gbrayut

gbrayut Jul 27, 2016

Contributor

tested and LGTM

Contributor

gbrayut commented Jul 27, 2016

tested and LGTM

@gbrayut gbrayut merged commit d1b7d83 into master Jul 27, 2016

2 checks passed

bosun All checks Passed!
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gbrayut gbrayut deleted the bufferpool branch Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment