New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: don't try to clean IP addresses. Also don't clean twice on Set #1902

Merged
merged 1 commit into from Sep 12, 2016

Conversation

Projects
None yet
2 participants
@gbrayut
Contributor

gbrayut commented Sep 7, 2016

No description provided.

@gbrayut

This comment has been minimized.

Show comment
Hide comment
@gbrayut

gbrayut Sep 7, 2016

Contributor

Addresses part of #1862

Tested locally and it works using ipv4 address as hostname. IPv6 addresses don't use .s so they won't have the same split issue.

Contributor

gbrayut commented Sep 7, 2016

Addresses part of #1862

Tested locally and it works using ipv4 address as hostname. IPv6 addresses don't use .s so they won't have the same split issue.

@captncraig

This comment has been minimized.

Show comment
Hide comment
@captncraig

captncraig Sep 12, 2016

Contributor

lgtm

Contributor

captncraig commented Sep 12, 2016

lgtm

@gbrayut gbrayut merged commit 19f8e01 into master Sep 12, 2016

2 checks passed

bosun All checks Passed!
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gbrayut gbrayut deleted the util branch Sep 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment