Have opentsdb.Duration implement encoding.TextUnmarshaler. #1975

Merged
merged 1 commit into from Dec 1, 2016

Conversation

Projects
None yet
3 participants
@alienth
Contributor

alienth commented Nov 30, 2016

馃憮 @captncraig @kylebrandt

Will be using this to read durations from a config file on a separate utility.

@captncraig

This comment has been minimized.

Show comment
Hide comment
@captncraig

captncraig Dec 1, 2016

Contributor

Lgtm

Contributor

captncraig commented Dec 1, 2016

Lgtm

@kylebrandt

This comment has been minimized.

Show comment
Hide comment
@kylebrandt

kylebrandt Dec 1, 2016

Member
Member

kylebrandt commented Dec 1, 2016

@alienth

This comment has been minimized.

Show comment
Hide comment
@alienth

alienth Dec 1, 2016

Contributor

Not sure if I'll be around during your morning time. Mind prodding at this via comments?

For further context, this is so I can json/toml unmarshal a file straight into a struct containing an opentsdb.Duration field.

Contributor

alienth commented Dec 1, 2016

Not sure if I'll be around during your morning time. Mind prodding at this via comments?

For further context, this is so I can json/toml unmarshal a file straight into a struct containing an opentsdb.Duration field.

@kylebrandt

This comment has been minimized.

Show comment
Hide comment
@kylebrandt

kylebrandt Dec 1, 2016

Member
Member

kylebrandt commented Dec 1, 2016

@alienth

This comment has been minimized.

Show comment
Hide comment
@alienth

alienth Dec 1, 2016

Contributor

Gotcha, works for me. Thanks!

Contributor

alienth commented Dec 1, 2016

Gotcha, works for me. Thanks!

@kylebrandt kylebrandt merged commit e969726 into bosun-monitor:master Dec 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment