Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/scollector: Update linux interface collector names. #1985

Merged
merged 1 commit into from Feb 22, 2018

Conversation

@sysadmind
Copy link
Contributor

@sysadmind sysadmind commented Dec 14, 2016

Add systemd predictable network interface names into linux network name regex. The systemd mention of these prefixes exists here: https://github.com/systemd/systemd/blob/master/src/udev/udev-builtin-net_id.c#L29

This adds ww, wl, and en to the possible prefixes for interface names and also changes the space up front to be optional. When the names get too long for the column, I have noticed that the text aligns to the start of the line instead of the colon.

This should fix issues others have been having with network interfaces not showing up.
Related:
#1756
#1912

@sysadmind sysadmind changed the title Update linux interface collector names. cmd/scollector: Update linux interface collector names. Dec 15, 2016
Copy link

@peterfroehlich peterfroehlich left a comment

Successfully validated regex against all possible interface names

@peterfroehlich
Copy link

@peterfroehlich peterfroehlich commented Feb 22, 2018

@kylebrandt could you please review and approve this PR?
Sadly systemd is not really something that can be ignored anymore...

@kylebrandt kylebrandt merged commit db70a05 into bosun-monitor:master Feb 22, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peterfroehlich
Copy link

@peterfroehlich peterfroehlich commented Feb 22, 2018

Thanks! ❤️

dschneller added a commit to Rheinwerk/bosun that referenced this pull request Feb 26, 2018
* master:
  cmd/scollector: add systemd physical "predictable" linux net interface names (bosun-monitor#1985)
  cmd/bosun: add notification stats to /api/health (bosun-monitor#2222)
  cmd/bosun: native short links replace google (bosun-monitor#2210)
  docs: update system_configuration docs to reflect RedisDb configuration variable (bosun-monitor#2220)
  cmd/bosun/sched/views.go: added new incident filter `since` (bosun-monitor#2215)
  Bosun complaining about `actionBodyForceClose`, `actionBodyDelayedClose`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198)
  Update WMI to support int[] (bosun-monitor#2213)
  Add Scheme option to bosun toml (bosun-monitor#2209)
  Changed load sequence for `macros` to use in the notifications (bosun-monitor#2199)
  Fixed wrong nested ul in unknown notify (bosun-monitor#2208)
  travis: remove slack notification / go 1.9 (bosun-monitor#2203)
  Fix post notification logging (bosun-monitor#2196)
clinta added a commit to clinta/bosun that referenced this pull request Mar 9, 2018
pradeepbbl pushed a commit to pradeepbbl/bosun that referenced this pull request Mar 21, 2018
michep pushed a commit to michep/bosun that referenced this pull request Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants