This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Repository navigation
cmd/scollector: Update linux interface collector names. - #1985
Merged
Merged
Conversation
sysadmind
changed the title
peterfroehlich
approved these changes
Feb 22, 2018
peterfroehlich
left a comment
peterfroehlich
left a comment
There was a problem hiding this comment.
Successfully validated regex against all possible interface names
|
@kylebrandt could you please review and approve this PR? |
|
Thanks! ❤️ |
dschneller
added a commit
to Rheinwerk/bosun
that referenced
this pull request
Feb 26, 2018
* master: cmd/scollector: add systemd physical "predictable" linux net interface names (bosun-monitor#1985) cmd/bosun: add notification stats to /api/health (bosun-monitor#2222) cmd/bosun: native short links replace google (bosun-monitor#2210) docs: update system_configuration docs to reflect RedisDb configuration variable (bosun-monitor#2220) cmd/bosun/sched/views.go: added new incident filter `since` (bosun-monitor#2215) Bosun complaining about `actionBodyForceClose`, `actionBodyDelayedClose`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198) Update WMI to support int[] (bosun-monitor#2213) Add Scheme option to bosun toml (bosun-monitor#2209) Changed load sequence for `macros` to use in the notifications (bosun-monitor#2199) Fixed wrong nested ul in unknown notify (bosun-monitor#2208) travis: remove slack notification / go 1.9 (bosun-monitor#2203) Fix post notification logging (bosun-monitor#2196)
clinta
pushed a commit
to clinta/bosun
that referenced
this pull request
Mar 9, 2018
…e names (bosun-monitor#1985) adds: en — ethernet, wl — wlan, and ww — wwan. See https://github.com/systemd/systemd/blob/v237/src/udev/udev-builtin-net_id.c#L30 as reference.
pradeepbbl
pushed a commit
to pradeepbbl/bosun
that referenced
this pull request
Mar 21, 2018
…e names (bosun-monitor#1985) adds: en — ethernet, wl — wlan, and ww — wwan. See https://github.com/systemd/systemd/blob/v237/src/udev/udev-builtin-net_id.c#L30 as reference.
michep
pushed a commit
to michep/bosun
that referenced
this pull request
Apr 23, 2018
…e names (bosun-monitor#1985) adds: en — ethernet, wl — wlan, and ww — wwan. See https://github.com/systemd/systemd/blob/v237/src/udev/udev-builtin-net_id.c#L30 as reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add systemd predictable network interface names into linux network name regex. The systemd mention of these prefixes exists here: https://github.com/systemd/systemd/blob/master/src/udev/udev-builtin-net_id.c#L29
This adds
ww,wl, andento the possible prefixes for interface names and also changes the space up front to be optional. When the names get too long for the column, I have noticed that the text aligns to the start of the line instead of the colon.This should fix issues others have been having with network interfaces not showing up.
Related:
#1756
#1912