Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/scollector: Updated Azure EA collector to add new tags. #2011

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

mhenderson-so
Copy link
Contributor

Also converted to better invocation style.

@mhenderson-so
Copy link
Contributor Author

I re-pushed this PR, as it never got merged when I originally submitted it, because the TravisCI job was borked back then. I haven't actually changed anything between now and then - but now the checks pass.

If you are a heavy Azure EA user, then these additional tags may be useful for breaking down costs.

[[AzureEA]]
EANumber = "123456"
APIKey = "joiIiwiaXNzIjoiZWEubWljcm9zb2Z0YXp1cmUuY29tIiwiYXVkIjoiY2xpZW50LmVhLm1"
LogBillingDetails = false
LogResourceDetails = false
LogExtraTags = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think spacing is off just a tad here.

Copy link
Contributor

@captncraig captncraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the one minor doc spacing issue.

@captncraig captncraig merged commit 289979c into bosun-monitor:master Aug 31, 2017
@mhenderson-so mhenderson-so deleted the AzureDetail branch September 22, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants