New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/scollector: Updated Azure EA collector to add new tags. #2011

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Projects
None yet
2 participants
@mhenderson-so
Contributor

mhenderson-so commented Feb 2, 2017

Also converted to better invocation style.

@mhenderson-so

This comment has been minimized.

Contributor

mhenderson-so commented Aug 30, 2017

I re-pushed this PR, as it never got merged when I originally submitted it, because the TravisCI job was borked back then. I haven't actually changed anything between now and then - but now the checks pass.

If you are a heavy Azure EA user, then these additional tags may be useful for breaking down costs.
[[AzureEA]]
EANumber = "123456"
APIKey = "joiIiwiaXNzIjoiZWEubWljcm9zb2Z0YXp1cmUuY29tIiwiYXVkIjoiY2xpZW50LmVhLm1"
LogBillingDetails = false
LogResourceDetails = false
LogExtraTags = false

This comment has been minimized.

@captncraig

captncraig Aug 31, 2017

Contributor

I think spacing is off just a tad here.

@captncraig

LGTM with the one minor doc spacing issue.

@captncraig captncraig merged commit 289979c into bosun-monitor:master Aug 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mhenderson-so mhenderson-so deleted the mhenderson-so:AzureDetail branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment