This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/scollector: Updated Azure EA collector to add new tags. #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I re-pushed this PR, as it never got merged when I originally submitted it, because the TravisCI job was borked back then. I haven't actually changed anything between now and then - but now the checks pass. |
captncraig
reviewed
Aug 31, 2017
cmd/scollector/doc.go
Outdated
| APIKey = "joiIiwiaXNzIjoiZWEubWljcm9zb2Z0YXp1cmUuY29tIiwiYXVkIjoiY2xpZW50LmVhLm1" | ||
| LogBillingDetails = false | ||
| LogResourceDetails = false | ||
| LogExtraTags = false |
Contributor
There was a problem hiding this comment.
I think spacing is off just a tad here.
captncraig
reviewed
Aug 31, 2017
Contributor
captncraig
left a comment
captncraig
left a comment
There was a problem hiding this comment.
LGTM with the one minor doc spacing issue.
… to better invocation style.
mhenderson-so
force-pushed
the
AzureDetail
branch
from
81a0170 to
a15d067
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also converted to better invocation style.