Add ackTime to incident filters #2014

Merged
merged 2 commits into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@kylebrandt
Member

kylebrandt commented Feb 10, 2017

This lets you show incidents that were acknowledged more than X time ago. A useful view to scan for things in ack that maybe need to be resolved.

@kylebrandt kylebrandt requested a review from gbrayut Feb 10, 2017

@gbrayut

This comment has been minimized.

Show comment
Hide comment
@gbrayut

gbrayut Feb 10, 2017

Contributor

two comments, otherwise LGTM

Contributor

gbrayut commented Feb 10, 2017

two comments, otherwise LGTM

docs/usage.md
+ range specified in Grafana. For example, <code>ackTime:<24h</code> shows incidents that were acknowledged more than 24 hours ago.</td>
+ </tr>
+ <tr>
+ <td><code>ackTime:(true|false)</code></td>

This comment has been minimized.

@gbrayut

gbrayut Feb 10, 2017

Contributor

Is this suppose to be ack: instead of ackTime: ?

@gbrayut

gbrayut Feb 10, 2017

Contributor

Is this suppose to be ack: instead of ackTime: ?

docs/usage.md
@@ -88,7 +88,15 @@ The open incident filter supports joining terms in `()` as well as the `AND`, `O
<th>Description</th>
</tr>
<tr>
- <td><code>ack:(true|false)</code></td>
+ <td><code>ackTime:[<|>](1d)</code></td>

This comment has been minimized.

@gbrayut

gbrayut Feb 10, 2017

Contributor

this looks like it is not indented correctly

@gbrayut

gbrayut Feb 10, 2017

Contributor

this looks like it is not indented correctly

@kylebrandt kylebrandt merged commit 8866155 into master Feb 10, 2017

2 checks passed

bosun All checks Passed!
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kylebrandt kylebrandt deleted the ackAgoFilter branch Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment