cmd/scollector: enable SWbemServices worker for better WMI performance in Windows #2028

Merged
merged 3 commits into from Mar 1, 2017

Conversation

Projects
None yet
1 participant
@gbrayut
Contributor

gbrayut commented Feb 21, 2017

This updates the WMI package to include the SWbemServices updates from StackExchange/wmi#23

I plan on testing this in our environment to make sure things are stable. Shouldn't cause any issues as everything is behind the UseSWbemServicesClient = true value in scollector.toml

gbrayut added some commits Feb 21, 2017

cmd/scollector: wait for Windows service to start before returning fr…
…om win_service_main()

This should prevent the service startup errors we were seeing indicating it was being unresponsive
cmd/scollector: enable SWbemServices worker using UseSWbemServicesCli…
…ent = true in toml file. Also add expvars when pprof is enabled.
cmd/scollector: vendor StackExchange/mof changes to support NULL stri…
…ngs. Use __no_name__ if c_dsc_status collector has any NULL ConfigurationName values

@gbrayut gbrayut merged commit ea52fac into master Mar 1, 2017

3 checks passed

bosun All checks Passed!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gbrayut gbrayut deleted the wmi branch Mar 1, 2017

@gbrayut

This comment has been minimized.

Show comment
Hide comment
@gbrayut

gbrayut Mar 1, 2017

Contributor

We didn't find any issues when testing, and this has been rolled out to all our Windows servers now. The default is still using the old code, you still have to specify UseSWbemServicesClient = true to use the new code. In the future we may change that to be the default.

Contributor

gbrayut commented Mar 1, 2017

We didn't find any issues when testing, and this has been rolled out to all our Windows servers now. The default is still using the old code, you still have to specify UseSWbemServicesClient = true to use the new code. In the future we may change that to be the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment