New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/scollector: Fixed bug in ElasticSearch collector for Elastic 5.x #2155

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Projects
None yet
2 participants
@mhenderson-so
Contributor

mhenderson-so commented Aug 31, 2017

Elastic 5.x route of /_nodes/_local/stats emits a single IP address,
such as

"ip": "10.7.1.74:9300"

However prior to v5 this is an array:

"ip": [
	"10.7.1.74:9300"
],

We do not use the IP address attribute from this route anywhere in the
collector, so removing it from the JSON decoding stops the error, and has no
impact on the collectors functionality (apart from making it work again).

cmd/scollector: Fixed bug in ElasticSearch collector for Elastic 5.x:
Elastic 5.x route of `/_nodes/_local/stats` emits a single IP address,
such as

```
"ip": "10.7.1.74:9300"
````

However prior to v5 this is an array:

```
"ip": [
	"10.7.1.74:9300"
],
```

We do not use the IP address attribute from this route anywhere in the
collector, so removing it from the JSON decoding stops the error, and has no
impact on the collectors functionality (apart from making it work again).

@captncraig captncraig merged commit 7d5f9ef into bosun-monitor:master Aug 31, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@mhenderson-so mhenderson-so deleted the mhenderson-so:Elastic5Bugfix branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment