/bosun

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/scollector: Fix bug in AWS billing collector. #2156

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Reviewers

@captncraig captncraig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mhenderson-so @kylebrandt @captncraig
@mhenderson-so
Contributor

mhenderson-so commented Aug 31, 2017

The billing collector did not correctly account for Route 53 zone billing
where the bill contains an empty zone name.

This fixes issue #2147
@mhenderson-so
cmd/scollector: Fix bug in AWS billing collector. 
The billing collector did not correctly account for Route 53 zone billing
where the bill contains an empty zone name.

This fixes issue #2147
98fb60f

@captncraig captncraig merged commit 964118f into bosun-monitor:master Aug 31, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kylebrandt

This comment has been minimized.

Sign in to view
Member

kylebrandt commented Sep 18, 2017

This now results in errors because operation doesn't have a value. Maybe you can take another look @captncraig ?:

Sep 18 16:16:10 ny-bosun01.ds.stackexchange.com scollector[10591]: error: collectors.go:274: Invalid tagset discovered: {host=ny-bosun01,operation=,usagetype=USW2-Requests-Tier3}. Skipping datapoint. Added from: awsBilling.go:251
Sep 18 16:16:10 ny-bosun01.ds.stackexchange.com scollector[10591]: error: collectors.go:274: Invalid tagset discovered: {host=ny-bosun01,operation=,usagetype=USW2-Requests-Tier3}. Skipping datapoint. Added from: awsBilling.go:252
Sep 18 16:16:10 ny-bosun01.ds.stackexchange.com scollector[10591]: error: collectors.go:274: Invalid tagset discovered: {host=ny-bosun01,operation=,usagetype=USW2-Expedited-Retrieval-Bytes}. Skipping datapoint. Added from: awsBilling.go:251
Sep 18 16:16:10 ny-bosun01.ds.stackexchange.com scollector[10591]: error: collectors.go:274: Invalid tagset discovered: {host=ny-bosun01,operation=,usagetype=USW2-Expedited-Retrieval-Bytes}. Skipping datapoint. Added from: awsBilling.go:252

@mhenderson-so mhenderson-so deleted the mhenderson-so:AWSBugfix branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment