This repository was archived by the owner on Feb 13, 2025. It is now read-only.
cmd/scollector: Fix bug in AWS billing collector. - #2156
Merged
Conversation
The billing collector did not correctly account for Route 53 zone billing where the bill contains an empty zone name. This fixes issue bosun-monitor#2147
captncraig
approved these changes
Aug 31, 2017
Member
|
This now results in errors because operation doesn't have a value. Maybe you can take another look @captncraig ?: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The billing collector did not correctly account for Route 53 zone billing
where the bill contains an empty zone name.
This fixes issue #2147