Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPurge old Rendered Templates #2167
Conversation
captncraig
added some commits
Sep 25, 2017
| continue | ||
| } | ||
| fmt.Println(st.Id, len(st.Events), st.Open) | ||
| s, err := redis.String(myConn.Do("GET", fmt.Sprintf("renderedTemplatesById:%d", st.Id))) |
This comment has been minimized.
This comment has been minimized.
captncraig
added some commits
Sep 29, 2017
captncraig
changed the title from
WIP: Purge old Templates
to
Purge old Rendered Templates
Oct 10, 2017
captncraig
added some commits
Oct 10, 2017
cmd/bosun/database/state_data.go
Outdated
| } | ||
| state, err := d.getIncident(id, conn) | ||
| if err != nil { | ||
| if strings.Contains(err.Error(), "nil returned") { |
This comment has been minimized.
This comment has been minimized.
kylebrandt
Oct 10, 2017
Member
strings.Contains on error, combined with the match not being a constant doesn't seem safe in the long run.
This comment has been minimized.
This comment has been minimized.
captncraig
Oct 13, 2017
Contributor
Yeah, the problem there is that the error will already be wrapped at that point, and the inner error is not accessible. I guess I can also make a package function for that test though.
cmd/bosun/database/state_data.go
Outdated
| //ledis uses XSCAN cursor "KV" MATCH foo | ||
| //redis uses SCAN cursor MATCH foo | ||
| cmd := "SCAN" |
This comment has been minimized.
This comment has been minimized.
kylebrandt
Oct 10, 2017
Member
Maybe Redis and Ledis SCAN could be a function outside of this that can be reused (and make this func shorter)
This comment has been minimized.
This comment has been minimized.
captncraig
Oct 13, 2017
Contributor
Yeah, we did that with some others, but the re-ordering of the args makes it tricky. I will factor out.
This comment has been minimized.
This comment has been minimized.
|
@captncraig Didn't find any problems testing this out, but needs conflicts resolved. |
kylebrandt
merged commit 3866edf
into
master
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kylebrandt commentedSep 29, 2017
No description provided.