New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post notification logging #2196

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@pradeepbbl
Contributor

pradeepbbl commented Nov 28, 2017

This will add alert key and notification name to HTTP notification failure log.

Current failure log:

2017/11/21 14:15:41 error: notify.go:48: sending http: bad response on notification POST: 400

With this change:

2017/11/28 15:17:18 error: notify.go:48: sending http: bad response on notification with name bosun_uptime for alert bosun_uptime{} method POST: 400
@pradeepbbl

This comment has been minimized.

Contributor

pradeepbbl commented Nov 28, 2017

looping @kylebrandt

@captncraig captncraig merged commit 68d0640 into bosun-monitor:master Nov 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

hermanschaaf pushed a commit to hermanschaaf/bosun that referenced this pull request Jan 5, 2018

@pradeepbbl pradeepbbl referenced this pull request Feb 12, 2018

Merged

Fix notifications log #2218

dschneller added a commit to Rheinwerk/bosun that referenced this pull request Feb 26, 2018

Merge branch 'master' into ES-TLS
* master:
  cmd/scollector: add systemd physical "predictable" linux net interface names (bosun-monitor#1985)
  cmd/bosun: add notification stats to /api/health (bosun-monitor#2222)
  cmd/bosun: native short links replace google (bosun-monitor#2210)
  docs: update system_configuration docs to reflect RedisDb configuration variable (bosun-monitor#2220)
  cmd/bosun/sched/views.go: added new incident filter `since` (bosun-monitor#2215)
  Bosun complaining about `actionBodyForceClose`, `actionBodyDelayedClose`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198)
  Update WMI to support int[] (bosun-monitor#2213)
  Add Scheme option to bosun toml (bosun-monitor#2209)
  Changed load sequence for `macros` to use in the notifications (bosun-monitor#2199)
  Fixed wrong nested ul in unknown notify (bosun-monitor#2208)
  travis: remove slack notification / go 1.9 (bosun-monitor#2203)
  Fix post notification logging (bosun-monitor#2196)

clinta added a commit to clinta/bosun that referenced this pull request Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment