Bosun complaining about `actionBodyForceClose`, `actionBodyDelayedClo` and `actionBodyCancelClose` #2198
Conversation
…se`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type Debug log: ``` 2017/11/29 11:27:26 enabling syslog 2017/11/29 11:27:26 info: loaders.go:439: Key was: actionBodyDelayedClose 2017/11/29 11:27:26 info: loaders.go:442: Key after trim action: BodyDelayedClose 2017/11/29 11:27:26 info: loaders.go:448: ActionType: Closed 2017/11/29 11:27:26 info: loaders.go:450: Template keyType: BodyDelayed 2017/11/29 11:27:26 fatal: main.go:119: couldn't read rules: conf: test01.conf:34:3: at <actionBodyDelayedClo...>: unknown key actionBodyDelayedClose ``` In this patch, we try to match the actionType explicitly with strings.Compare
|
lopping @captncraig for a review :) |
|
@captncraig could you please review this and let me know your thoughts. |
captncraig
merged commit c9590d0
into
bosun-monitor:master
1 check passed
1 check passed
dschneller
added a commit
to Rheinwerk/bosun
that referenced
this pull request
Feb 26, 2018
* master: cmd/scollector: add systemd physical "predictable" linux net interface names (bosun-monitor#1985) cmd/bosun: add notification stats to /api/health (bosun-monitor#2222) cmd/bosun: native short links replace google (bosun-monitor#2210) docs: update system_configuration docs to reflect RedisDb configuration variable (bosun-monitor#2220) cmd/bosun/sched/views.go: added new incident filter `since` (bosun-monitor#2215) Bosun complaining about `actionBodyForceClose`, `actionBodyDelayedClose`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198) Update WMI to support int[] (bosun-monitor#2213) Add Scheme option to bosun toml (bosun-monitor#2209) Changed load sequence for `macros` to use in the notifications (bosun-monitor#2199) Fixed wrong nested ul in unknown notify (bosun-monitor#2208) travis: remove slack notification / go 1.9 (bosun-monitor#2203) Fix post notification logging (bosun-monitor#2196)
clinta
added a commit
to clinta/bosun
that referenced
this pull request
Mar 9, 2018
…se`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198) Debug log: ``` 2017/11/29 11:27:26 enabling syslog 2017/11/29 11:27:26 info: loaders.go:439: Key was: actionBodyDelayedClose 2017/11/29 11:27:26 info: loaders.go:442: Key after trim action: BodyDelayedClose 2017/11/29 11:27:26 info: loaders.go:448: ActionType: Closed 2017/11/29 11:27:26 info: loaders.go:450: Template keyType: BodyDelayed 2017/11/29 11:27:26 fatal: main.go:119: couldn't read rules: conf: test01.conf:34:3: at <actionBodyDelayedClo...>: unknown key actionBodyDelayedClose ``` In this patch, we try to match the actionType explicitly with strings.Compare
pradeepbbl
added a commit
to pradeepbbl/bosun
that referenced
this pull request
Mar 21, 2018
…se`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198) Debug log: ``` 2017/11/29 11:27:26 enabling syslog 2017/11/29 11:27:26 info: loaders.go:439: Key was: actionBodyDelayedClose 2017/11/29 11:27:26 info: loaders.go:442: Key after trim action: BodyDelayedClose 2017/11/29 11:27:26 info: loaders.go:448: ActionType: Closed 2017/11/29 11:27:26 info: loaders.go:450: Template keyType: BodyDelayed 2017/11/29 11:27:26 fatal: main.go:119: couldn't read rules: conf: test01.conf:34:3: at <actionBodyDelayedClo...>: unknown key actionBodyDelayedClose ``` In this patch, we try to match the actionType explicitly with strings.Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Bosun complaining about
actionBodyForceClose,actionBodyDelayedClose, andactionBodyCancelCloseintermediately and causing crash with errorcouldn't read rules: unknown key actionBodyDelayedCloseafter looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks in the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template typeDebug log:
In this patch, we try to match the actionType explicitly with strings.Compare