This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Bosun complaining about actionBodyForceClose
, actionBodyDelayedClo
and actionBodyCancelClose
#2198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bosun complaining about
actionBodyForceClose
,actionBodyDelayedClose
, andactionBodyCancelClose
intermediately and causing crash with errorcouldn't read rules: unknown key actionBodyDelayedClose
after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks in the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template typeDebug log:
In this patch, we try to match the actionType explicitly with strings.Compare