/bosun

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macros for Notifications #2199

Merged
merged 1 commit into from Jan 2, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pradeepbbl @captncraig
@pradeepbbl
Contributor

pradeepbbl commented Dec 4, 2017

Load macros before notifications, so that we can able use it in notifications which will reduce the duplications.

#2194

@captncraig captncraig merged commit bb1d0b1 into bosun-monitor:master Jan 2, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

hermanschaaf pushed a commit to hermanschaaf/bosun that referenced this pull request Jan 5, 2018

@pradeepbbl Herman Schaaf
Changed load sequence for `macros` to use in the notifications (bosun… 
…-monitor#2199)
3b96b4d

@pradeepbbl pradeepbbl deleted the bookingcom:fix_macros branch Jan 9, 2018

dschneller added a commit to Rheinwerk/bosun that referenced this pull request Feb 26, 2018

@dschneller
Merge branch 'master' into ES-TLS 
* master:
  cmd/scollector: add systemd physical "predictable" linux net interface names (bosun-monitor#1985)
  cmd/bosun: add notification stats to /api/health (bosun-monitor#2222)
  cmd/bosun: native short links replace google (bosun-monitor#2210)
  docs: update system_configuration docs to reflect RedisDb configuration variable (bosun-monitor#2220)
  cmd/bosun/sched/views.go: added new incident filter `since` (bosun-monitor#2215)
  Bosun complaining about `actionBodyForceClose`, `actionBodyDelayedClose`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198)
  Update WMI to support int[] (bosun-monitor#2213)
  Add Scheme option to bosun toml (bosun-monitor#2209)
  Changed load sequence for `macros` to use in the notifications (bosun-monitor#2199)
  Fixed wrong nested ul in unknown notify (bosun-monitor#2208)
  travis: remove slack notification / go 1.9 (bosun-monitor#2203)
  Fix post notification logging (bosun-monitor#2196)
Verified
This commit was signed with a verified signature.
@dschneller dschneller Daniel Schneller
GPG key ID: 3519E4D53C5AD538 Learn about signing commits
ca332be

clinta added a commit to clinta/bosun that referenced this pull request Mar 9, 2018

@pradeepbbl @clinta
Changed load sequence for `macros` to use in the notifications (bosun… 
…-monitor#2199)
c40a35b

pradeepbbl added a commit to pradeepbbl/bosun that referenced this pull request Mar 21, 2018

@pradeepbbl Pradeep Mishra
Changed load sequence for `macros` to use in the notifications (bosun… 
…-monitor#2199)
b1c8ac7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment