/bosun

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native short links in bosun #2210

Merged
merged 2 commits into from Feb 18, 2018

Conversation

Reviewers

@kylebrandt kylebrandt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@captncraig @kylebrandt
@captncraig
Contributor

captncraig commented Jan 8, 2018

No description provided.

@captncraig captncraig requested a review from kylebrandt Jan 8, 2018

@captncraig

This comment has been minimized.

Sign in to view
Contributor

captncraig commented Jan 8, 2018

Google link shortener not supported any longer. We could remove the config key if we wanted to make that a breaking change.

Links now generate as {bosun-host}/s/123
cmd/bosun/conf/system.go Outdated
Host: sc.Hostname,
Path: path,
RawQuery: v.Encode(),
Scheme: "http",

This comment has been minimized.

Sign in to view
Copy link
@kylebrandt

kylebrandt Jan 8, 2018

Member

hardcoded http probably not good. I think someone has a PR regarding this.
@kylebrandt

This comment has been minimized.

Sign in to view
Member

kylebrandt commented Jan 8, 2018

@captncraig Can you expand on not supported anymore? In other words, what happens to people that using Google shortner and start using this branch?
@captncraig

This comment has been minimized.

Sign in to view
Contributor

captncraig commented Jan 8, 2018

Not supported anymore as in, we don't bother making a google shortlink. Just make our own. The code to call google is removed entirely.

@kylebrandt kylebrandt merged commit 8a0dc1e into master Feb 18, 2018
3 checks passed

3 checks passed

bosun All checks Passed!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kylebrandt kylebrandt deleted the short branch Feb 18, 2018

pradeepbbl pushed a commit to bookingcom/bosun that referenced this pull request Feb 19, 2018

@captncraig Pradeep Mishra
cmd/bosun: native short links replace google (bosun-monitor#2210) 
google is no longer used to generate short links instead, bosun generates its own links and stores them in redis/ledis.
095868b

dschneller added a commit to Rheinwerk/bosun that referenced this pull request Feb 26, 2018

@dschneller
Merge branch 'master' into ES-TLS 
* master:
  cmd/scollector: add systemd physical "predictable" linux net interface names (bosun-monitor#1985)
  cmd/bosun: add notification stats to /api/health (bosun-monitor#2222)
  cmd/bosun: native short links replace google (bosun-monitor#2210)
  docs: update system_configuration docs to reflect RedisDb configuration variable (bosun-monitor#2220)
  cmd/bosun/sched/views.go: added new incident filter `since` (bosun-monitor#2215)
  Bosun complaining about `actionBodyForceClose`, `actionBodyDelayedClose`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198)
  Update WMI to support int[] (bosun-monitor#2213)
  Add Scheme option to bosun toml (bosun-monitor#2209)
  Changed load sequence for `macros` to use in the notifications (bosun-monitor#2199)
  Fixed wrong nested ul in unknown notify (bosun-monitor#2208)
  travis: remove slack notification / go 1.9 (bosun-monitor#2203)
  Fix post notification logging (bosun-monitor#2196)
Verified
This commit was signed with a verified signature.
@dschneller dschneller Daniel Schneller
GPG key ID: 3519E4D53C5AD538 Learn about signing commits
ca332be

clinta added a commit to clinta/bosun that referenced this pull request Mar 9, 2018

@captncraig @clinta
cmd/bosun: native short links replace google (bosun-monitor#2210) 
google is no longer used to generate short links instead, bosun generates its own links and stores them in redis/ledis.
a418aa1

pradeepbbl pushed a commit to pradeepbbl/bosun that referenced this pull request Mar 21, 2018

@captncraig Pradeep Mishra
cmd/bosun: native short links replace google (bosun-monitor#2210) 
google is no longer used to generate short links instead, bosun generates its own links and stores them in redis/ledis.
7acf2a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment