Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending mail if 'To' slice empty #2217

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
2 participants
@pradeepbbl
Copy link
Contributor

pradeepbbl commented Feb 6, 2018

We have noticed when a post action notification triggered bosun also trying to send mail with empty 'To' address

2018/02/05 12:15:30 error: notify.go:49: sending email: Must specify at least one From address and one To address
2018/02/05 12:17:30 error: notify.go:205: failed to send alert to [] Must specify at least one From address and one To address

This patch will validate the 'To' address slice length and stop trying sending mail if it's empty

Thanks,

@pradeepbbl pradeepbbl force-pushed the bookingcom:fix_bad_email branch from 6ff2a17 to f65e956 Feb 21, 2018

@captncraig captncraig merged commit 7234211 into bosun-monitor:master Mar 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

clinta added a commit to clinta/bosun that referenced this pull request Mar 9, 2018

@pradeepbbl pradeepbbl deleted the bookingcom:fix_bad_email branch Mar 16, 2018

pradeepbbl added a commit to pradeepbbl/bosun that referenced this pull request Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.