Fix notifications log #2218
Merged
Fix notifications log #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradeepbbl
force-pushed
the
fix_notifications_log
branch
from
0b21b7b to
36c0f71
Compare
…fication failure debugging
- cmd/bosun/conf/[actionNotify.go, unknownNotify.go]: modified NotificationDetails struct to include temaplte key map and action string
- cmd/bosun/conf/notify.go: modified PrepareAlert func and notifiaction failure message
pradeepbbl
force-pushed
the
fix_notifications_log
branch
from
36c0f71 to
6c53990
Compare
pradeepbbl
added a commit
to pradeepbbl/bosun
that referenced
this pull request
Mar 21, 2018
…fication failure debugging (bosun-monitor#2218) - cmd/bosun/conf/[actionNotify.go, unknownNotify.go]: modified NotificationDetails struct to include temaplte key map and action string - cmd/bosun/conf/notify.go: modified PrepareAlert func and notifiaction failure message
michep
pushed a commit
to michep/bosun
that referenced
this pull request
Apr 23, 2018
…fication failure debugging (bosun-monitor#2218) - cmd/bosun/conf/[actionNotify.go, unknownNotify.go]: modified NotificationDetails struct to include temaplte key map and action string - cmd/bosun/conf/notify.go: modified PrepareAlert func and notifiaction failure message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up to our last PR #2196, we still having difficulties to trace notifications failures due to missing alert key's for action and unknown notifications e.g. mentioned below is an error sample we are getting more often
2018/02/08 16:31:44 error: notify.go:55: sending http: bad response on notification with name memcached_pagerduty for alert method POST: 400As you can see it's very difficult to find out details like for which alert it's failing and either it's an action notification or an unknown etc, with this change we will be able to get more details e.g
2018/02/09 15:28:06 error: notify.go:56: sending http: bad response for 'memcached_pagerduty' unknown notification using template key '' for alert keys memcached_memory_usage{host=XXXXXXX} method POST: 400With above we can see the
unknownnotification is failing due to missing template key and bosun trying to render the default HTML template which in this case will fail because PagerDuty event requires JSON.Thanks,