New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new api endpoint /api/debug/{key} #2222
Added new api endpoint /api/debug/{key} #2222
Conversation
@pradeepbbl Thanks for this, can you move them to /api/health instead? Maybe just a notifications object inside the current root object with these counters.
|
@kylebrandt thanks for the review, made the requested changes do let me know if need any further changes.
Thanks, |
@pradeepbbl Not sure why the short links commit is in here, rebase on master and force push to your branch maybe? |
Sorry my bad instead rebase I did a merge :(
…On 19 Feb 2018 11:59 PM, "Kyle Brandt" ***@***.***> wrote:
@pradeepbbl <https://github.com/pradeepbbl> Not sure why the short links
commit is in here, rebase on master and force push to your branch maybe?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2222 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGjlfk6I3paUnxbM2eeBoYzf31-lK21Vks5tWfzNgaJpZM4SG6JJ>
.
|
- cmd/bosun/conf/notify.go: Added two new metric 'bosun.post.sent' and 'bosun.post.sent_failed' - cmd/bosun/web/web.go: New api api endpoint 'api/debug/{key}' to expose bosun internal debug and performance stats - collect/collect.go: Added a new function 'Get', retrun current value of given metric from 'counters' - docs/api.md: Update new endpoint 'api/debug/{key}'
1f0135c
to
1949502
Compare
… '/api/health' - cmd/bosun/web/web.go: remove '/api/debug/{key}' route and func 'DebugStats' - docs/api.md: remove section 'Debug Endpoints' and updated '/api/health' doc
@kylebrandt / @captncraig can this merge along with #2217 Thanks, |
* master: cmd/scollector: add systemd physical "predictable" linux net interface names (bosun-monitor#1985) cmd/bosun: add notification stats to /api/health (bosun-monitor#2222) cmd/bosun: native short links replace google (bosun-monitor#2210) docs: update system_configuration docs to reflect RedisDb configuration variable (bosun-monitor#2220) cmd/bosun/sched/views.go: added new incident filter `since` (bosun-monitor#2215) Bosun complaining about `actionBodyForceClose`, `actionBodyDelayedClose`, `actionBodyCancelClose` intermediately and causing crash with error `couldn't read rules: unknown key actionBodyDelayedClose` after looking at the code cmd/bosun/conf/rule/loaders.go#L442 we found strings.HasSuffix sometime getting matched with 'Close' rather then 'DelayedClose, ForceClose or CancelClose' and later it breaks the switch statement cmd/bosun/conf/rule/loaders.go#L462 due to invalid template type (bosun-monitor#2198) Update WMI to support int[] (bosun-monitor#2213) Add Scheme option to bosun toml (bosun-monitor#2209) Changed load sequence for `macros` to use in the notifications (bosun-monitor#2199) Fixed wrong nested ul in unknown notify (bosun-monitor#2208) travis: remove slack notification / go 1.9 (bosun-monitor#2203) Fix post notification logging (bosun-monitor#2196)
- Added new metrics 'bosun.post.sent' and 'bosun.post.sent_failed' - collect/collect.go: Added a new function 'Get', to return the current value of given metric from 'counters'
- Added new metrics 'bosun.post.sent' and 'bosun.post.sent_failed' - collect/collect.go: Added a new function 'Get', to return the current value of given metric from 'counters'
Currently, bosun collects a bunch of runtime debug and performance stats and write it back to OpenTSDB. This endpoint will expose these stats, useful when you are not using Bosun with OpenTSDB.
At present, the endpoint only exposes
notification
success and failure stats but we can add any other stats in future if required.Thanks,