We have noticed sometimes ES config maps are getting conflicts when using multiple ES cluster with client options enable. #2239
Conversation
…sing multiple ES cluster with client option enable. This patch will fix this by moving the `addClientOptions` and `esConf` inside the for loop
- conf/system_elastic2.go :- moved `addClientOptions` and `esConf` inside the for loop
- conf/system_elastic5.go :- moved `addClientOptions` and `esConf` inside the for loop
captncraig
merged commit 90a0800
into
bosun-monitor:master
1 check passed
1 check passed
michep
pushed a commit
to michep/bosun
that referenced
this pull request
Apr 23, 2018
…sing multiple ES cluster with client option enable. This patch will fix this by moving the `addClientOptions` and `esConf` inside the for loop (bosun-monitor#2239) - conf/system_elastic2.go :- moved `addClientOptions` and `esConf` inside the for loop - conf/system_elastic5.go :- moved `addClientOptions` and `esConf` inside the for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This patch will fix the ES cluster config maps by moving the
addClientOptionsandesConfinside the for loopThanks,