/bosun

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We have noticed sometimes ES config maps are getting conflicts when using multiple ES cluster with client options enable. #2239

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pradeepbbl @captncraig
@pradeepbbl
Contributor

pradeepbbl commented Apr 11, 2018

This patch will fix the ES cluster config maps by moving the addClientOptions and esConf inside the for loop

- conf/system_elastic2.go :-  moved `addClientOptions` and `esConf` inside the for loop
- conf/system_elastic5.go :-  moved `addClientOptions` and `esConf` inside the for loop

Thanks,
Pradeep Mishra
We have noticed sometimes ES config maps are getting conflicts when u… 
…sing multiple ES cluster with client option enable. This patch will fix this by moving the `addClientOptions` and `esConf` inside the for loop

    - conf/system_elastic2.go :-  moved `addClientOptions` and `esConf` inside the for loop
    - conf/system_elastic5.go :-  moved `addClientOptions` and `esConf` inside the for loop
8b82398

@captncraig captncraig merged commit 90a0800 into bosun-monitor:master Apr 11, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pradeepbbl pradeepbbl deleted the bookingcom:fix_es_multicluster branch Apr 12, 2018

michep pushed a commit to michep/bosun that referenced this pull request Apr 23, 2018

@pradeepbbl Mike Chepaykin
We have noticed sometimes ES config maps are getting conflicts when u… 
…sing multiple ES cluster with client option enable. This patch will fix this by moving the `addClientOptions` and `esConf` inside the for loop (bosun-monitor#2239)

- conf/system_elastic2.go :-  moved `addClientOptions` and `esConf` inside the for loop
    - conf/system_elastic5.go :-  moved `addClientOptions` and `esConf` inside the for loop
b550b1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment