New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/scollector: (wip) windows remote access services (ras) metrics #2245

Merged
merged 4 commits into from Apr 26, 2018

Conversation

Projects
None yet
2 participants
@kylebrandt
Member

kylebrandt commented Apr 24, 2018

No description provided.

kylebrandt added some commits Apr 24, 2018

@kylebrandt kylebrandt requested a review from captncraig Apr 25, 2018

}
// If RaMgmtSvc and has at least one entry - we monitor it
// TODO: Follow init / Enable, see if it is okay to scope `dst` this way
c.Enable = func() bool { return err == nil && len(dst) > 0 }

This comment has been minimized.

@kylebrandt

kylebrandt Apr 25, 2018

Member

@captncraig you know how this works? Should the lines above be inside the c.Enable func?

This comment has been minimized.

@captncraig

captncraig Apr 26, 2018

Contributor

I believe the enable fun runs periodically on the host. So if you want to have it continually check if those counters are avilible, yes, put all the above code into the func. If you want to check once on scollector startup, then don't use the Enable func, just don't insert the collector on line 28.

@kylebrandt kylebrandt merged commit ed10025 into master Apr 26, 2018

3 checks passed

bosun All checks Passed!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kylebrandt kylebrandt deleted the winras branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment