New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bosun: add percentiles to window func #2254

Merged
merged 3 commits into from May 18, 2018

Conversation

Projects
None yet
2 participants
@kylebrandt
Member

kylebrandt commented May 17, 2018

No description provided.

@kylebrandt kylebrandt requested a review from captncraig May 18, 2018

if isPerc {
fnArgs = append(fnArgs, reflect.ValueOf(fromScalar(percValue)))
}
fnResult := windowFn.Call(fnArgs)

This comment has been minimized.

@captncraig

captncraig May 18, 2018

Contributor

Where is the code that actually detects the new argument and applies the percentile? I'm still confused what windowFn.Call does differently with the new parameter.

This comment has been minimized.

@captncraig

captncraig May 18, 2018

Contributor

Oh, nevermind. It actually takes another arg. And gets selected by name and reflection above. Gotcha. LGTM

@kylebrandt kylebrandt merged commit 5cd2727 into master May 18, 2018

3 checks passed

bosun All checks Passed!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kylebrandt kylebrandt deleted the windowPerc branch Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment