Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/scollector: Added Elastic config options #2257

Merged

Conversation

chriswhite199
Copy link
Contributor

To address: #2256

@PeterGrace
Copy link
Member

Hi @chriswhite199, I'm going to see if I can help this PR along since I'd also like this functionality in scollector.

Copy link
Member

@PeterGrace PeterGrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been running this PR in my environment for the last four hours and it has worked as expected, asides from the fact that the elasticsearch collector has an assumption that it should only get index data from masters, which isn't feasible in all scenarios, but will require a separate issue/PR that is definitely not in scope of this change.

LGTM +1 on merge

@PeterGrace
Copy link
Member

@kylebrandt @captncraig if either of you fine humans would be so kind as to also give your +1 before someone smacks the merge button, that'd be fantabulous.

@captncraig captncraig merged commit 40c5f5b into bosun-monitor:master May 29, 2018
@chriswhite199 chriswhite199 deleted the scollector/add-elastic-options branch May 29, 2018 03:59
pradeepbbl pushed a commit to bookingcom/bosun that referenced this pull request Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants