Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upcmd/scollector: Added Elastic config options #2257
Conversation
This comment has been minimized.
This comment has been minimized.
|
Hi @chriswhite199, I'm going to see if I can help this PR along since I'd also like this functionality in scollector. |
PeterGrace
approved these changes
May 26, 2018
I've been running this PR in my environment for the last four hours and it has worked as expected, asides from the fact that the elasticsearch collector has an assumption that it should only get index data from masters, which isn't feasible in all scenarios, but will require a separate issue/PR that is definitely not in scope of this change.
LGTM +1 on merge
This comment has been minimized.
This comment has been minimized.
|
@kylebrandt @captncraig if either of you fine humans would be so kind as to also give your +1 before someone smacks the merge button, that'd be fantabulous. |
PeterGrace
referenced this pull request
May 26, 2018
Open
elasticsearch collector only submits index data if scollector is run on a master node #2259
captncraig
merged commit 40c5f5b
into
bosun-monitor:master
May 29, 2018
1 check passed
chriswhite199
deleted the
chriswhite199:scollector/add-elastic-options
branch
May 29, 2018
pushed a commit
to bookingcom/bosun
that referenced
this pull request
Jul 4, 2018
chriswhite199 commentedMay 24, 2018
To address: #2256