Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bosun: added setting for example expression in *.toml #2261

Merged

Conversation

@KozzyKoder
Copy link
Contributor

@KozzyKoder KozzyKoder commented May 28, 2018

Changes in this pull request:
-Added optional setting in *.toml file "ExampleExpression" which allows to setup default expression under "Expression" tab in web UI.
-fixed bug: after testing of empty expression other expressions can not be tested (button stops sending expressions to test)
-added error message if user tests empty expression

Why it is needed: currently default expression is defined in expr.ts file and works properly if opentsdb is configured. In other environments (where graphite configured for example) after opening of "Expression" tab user sees error message "expr: non existent function q" that confuses him a bit.

@KozzyKoder KozzyKoder force-pushed the bookingcom:vpestov/example-expression branch from da33dd9 to b67f298 Jun 4, 2018
@KozzyKoder KozzyKoder changed the title added setting for example expression in *.toml cmd/bosun: added setting for example expression in *.toml Jun 4, 2018
@kylebrandt kylebrandt merged commit f485714 into bosun-monitor:master Jun 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@KozzyKoder KozzyKoder deleted the bookingcom:vpestov/example-expression branch Jun 9, 2018
pradeepbbl pushed a commit to bookingcom/bosun that referenced this pull request Jun 18, 2018
pradeepbbl pushed a commit to bookingcom/bosun that referenced this pull request Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants