cmd/bosun fixed tags parameter for silencing button on dashboard #2265
Conversation
01e5aa3
into
bosun-monitor:master
1 check passed
1 check passed
pradeepbbl
pushed a commit
to bookingcom/bosun
that referenced
this pull request
Jun 18, 2018
pradeepbbl
pushed a commit
to bookingcom/bosun
that referenced
this pull request
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hello! Fixed small bug.
steps to reproduce:
expected:
silencing page will understand tags of the alert and fill them in the form
actual result:
when a link to the silencing page is formed we can see undefined instead of tag values, e.g.: https://bosun-host/silence?duration=2h&alert=some_alert&tags=undefined
on the opened silencing page you can see a red highlighted note on top of the page saying 'opentsdb: bad tag: undefined'
Thanks!