New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bosun fixed tags parameter for silencing button on dashboard #2265

Merged
merged 1 commit into from Jun 11, 2018

Conversation

Projects
None yet
2 participants
@KozzyKoder
Contributor

KozzyKoder commented Jun 9, 2018

Hello! Fixed small bug.

steps to reproduce:
  1. open bosun dashboard
  2. find any open incident
  3. click on the incident description, an accordeon panel will expand on a dashboard page showing more info about the incident
  4. click on any silencing button directly on dashboard page or just copy a link to the silencing page
expected:

silencing page will understand tags of the alert and fill them in the form

actual result:

when a link to the silencing page is formed we can see undefined instead of tag values, e.g.: https://bosun-host/silence?duration=2h&alert=some_alert&tags=undefined
on the opened silencing page you can see a red highlighted note on top of the page saying 'opentsdb: bad tag: undefined'

Thanks!

@captncraig captncraig merged commit 01e5aa3 into bosun-monitor:master Jun 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@KozzyKoder KozzyKoder deleted the bookingcom:vpestov/alert-state-tags-fix branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment