Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bosun replace textarea with aceeditor in expr #2266

Merged
merged 3 commits into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@KozzyKoder
Copy link
Contributor

KozzyKoder commented Jun 12, 2018

Hello,

We have UX troubles trying to utilize Expr editor which is basically just textarea: it doesn't have syntax highlight and monospace font.
That's why we've implemented AceEditor to expr editor.

this is reimplementation of another PR
which seems to be abandoned: #2201

Thanks!

@kylebrandt

This comment has been minimized.

Copy link
Member

kylebrandt commented Jun 28, 2018

I do like changing this to the ace editor, however I'd like to see two changes:

  • The expression page supports "shift-enter" to execute the expression, would like to keep that ability
  • I think the default height should be a little smaller (although probably a few more lines then current) so by default there is more screen real estate for results.
@kylebrandt

This comment has been minimized.

Copy link
Member

kylebrandt commented Jun 28, 2018

Oh, also the bosun logo animation seems to keep going until you run an expression, I think there is stop JS function to stop that on load

@KozzyKoder

This comment has been minimized.

Copy link
Contributor Author

KozzyKoder commented Jun 28, 2018

@kylebrandt fixed review issues

vladimir.pestov

@kylebrandt kylebrandt merged commit 4ec829a into bosun-monitor:master Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

pradeepbbl pushed a commit to bookingcom/bosun that referenced this pull request Jul 4, 2018

@KozzyKoder KozzyKoder deleted the bookingcom:vpestov/replace-textarea-with-ace-editor branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.