This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Added extra info to unknown templates - #2269
Merged
kylebrandt merged 1 commit intoSep 20, 2018
Merged
Conversation
- conf/unknownNotify.go: added incident states to unknown context and a new func `IncidentUnknownLink` to build unknown incident link. - sched/notify.go: modified `sendUnknownNotifications` func to pass incident states. - docs/definitions.md: unknown template document update
pradeepbbl
force-pushed
the
fix_unknown_notification
branch
from
June 20, 2018 14:06
934df2d to
73e14ed
Compare
Contributor
Author
|
here is an example of a PagerDuty alert body template if you make close attention to With this patch, we are able to produce the unknown body and post to PagerDuty successfully @kylebrandt / @captncraig could you please let us know your thoughts? |
Contributor
Author
|
can this be merged soon :) |
|
Hey @kylebrandt, @captncraig! |
sipidronov
pushed a commit
to sipidronov/bosun
that referenced
this pull request
Sep 21, 2018
- conf/unknownNotify.go: added incident states to unknown context and a new func `IncidentUnknownLink` to build unknown incident link. - sched/notify.go: modified `sendUnknownNotifications` func to pass incident states. - docs/definitions.md: unknown template document update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we have a very limited number of variable available to the unknown templates which prevent us to match the alert and action notification template (includes incident states) and sometimes unknowns are getting unnoticed due inconsistency (when using external notification systems e.g. pagerduty).
With this patch, I tried to include the alert states to unknown which is very useful when grouping disable using unknownMinGroupSize.
Please let me know your thoughts.