Added extra info to unknown templates #2269
Merged
Conversation
- conf/unknownNotify.go: added incident states to unknown context and a new func `IncidentUnknownLink` to build unknown incident link. - sched/notify.go: modified `sendUnknownNotifications` func to pass incident states. - docs/definitions.md: unknown template document update
934df2d
to
73e14ed
here is an example of a PagerDuty alert body template
if you make close attention to With this patch, we are able to produce the unknown body and post to PagerDuty successfully
@kylebrandt / @captncraig could you please let us know your thoughts? |
can this be merged soon :) |
Hey @kylebrandt, @captncraig! |
97302ba
into
bosun-monitor:master
1 check passed
1 check passed
sipidronov
pushed a commit
to sipidronov/bosun
that referenced
this pull request
Sep 21, 2018
- conf/unknownNotify.go: added incident states to unknown context and a new func `IncidentUnknownLink` to build unknown incident link. - sched/notify.go: modified `sendUnknownNotifications` func to pass incident states. - docs/definitions.md: unknown template document update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently, we have a very limited number of variable available to the unknown templates which prevent us to match the alert and action notification template (includes incident states) and sometimes unknowns are getting unnoticed due inconsistency (when using external notification systems e.g. pagerduty).
With this patch, I tried to include the alert states to unknown which is very useful when grouping disable using unknownMinGroupSize.
Please let me know your thoughts.