New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bosun remove not used errors column in rule editor #2270

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@KozzyKoder
Contributor

KozzyKoder commented Jun 21, 2018

Hello,
when testing alerts in Rule editor there's a table beneath the testing form.
this table should show number of alerts that resulted with errors, normals, crits and warnings:

image

Seems that 'Errors' column is left after this commit: e47fae4
where errors were moved outside of table. We suggest to remove this column from UI.

another suggestions: in case of several errors show them separately:
image

Another thing that's tricky to test with rule editor is unknowns. when you encounter unknown and try to reproduce it, you won't be able to do that with rule editor. Idea is to add a hint about this on the right side of test button:

image

Thanks!

@kylebrandt kylebrandt merged commit c0efbff into bosun-monitor:master Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@KozzyKoder KozzyKoder deleted the bookingcom:vpestov/remove-unused-errors-column branch Jun 28, 2018

pradeepbbl pushed a commit to bookingcom/bosun that referenced this pull request Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment