Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logs #2299

Merged
merged 3 commits into from Sep 24, 2018

Conversation

Projects
None yet
3 participants
@svagner
Copy link
Contributor

commented Sep 4, 2018

problem

Sometimes people would complain that notifications about close/ack were not delivered to them
it seems that it's not possible to easily debug that now with current state of logs.

There is no log entries about successfull sending acks and closes. Only log failures (e.g. 400 response)

  • notifications option 'print = true' also seems to not do anything for action notifications (even for failed notifications that are logged)
  • logs don't allow you to understand if 'Send notifications' checkbox was on or off

goal

  • log successful actions (similar to how it logs alert notifications)
  • print new logs according to 'notification' settings
  • improve error log format - write extra data about notification that has delivery problem
  • log actions if there wasn't set checkbox notification

changes:

  • add logging if there was action without notification
  • add logging for any actions/alerts
  • add extra felds to log messages

Stan Putrya added some commits Sep 4, 2018

Stan Putrya
improve logging while notifications
- add logging if there was action without notification
- add logging for any actions/alerts
- add extra felds to log message
@stepashka

This comment has been minimized.

Copy link

commented Sep 20, 2018

Hey @kylebrandt, @captncraig!
Any objections to this change? Is there something else we need to implement before this gets merged?
Thanks,
Anna

Show resolved Hide resolved cmd/bosun/conf/notify.go Outdated
Show resolved Hide resolved cmd/bosun/web/web.go Outdated
@svagner

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2018

Hi @kylebrandt ! Thanks for your comments. I've pushed changes. Could you please review again? Thanks!

@kylebrandt kylebrandt merged commit 95589fb into bosun-monitor:master Sep 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pradeepbbl pradeepbbl deleted the bookingcom:improve_logs branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.