Support connecting to multiple versions elasticsearch at runtime [beautified version of PR 2260] by bom-d-van · Pull Request #2316 · bosun-monitor/bosun

bom-d-van · 2018-09-24T15:46:04Z

With this patch bosun could connect to elasticsearch servers with different versions. Supported version are: 2.x, 5.x, 6.x. This is a breaking change, requiring users to update their configuration files to explicitly specify elasticsearch version with 2, 5, or 6, otherwise it would just panic (fail fast).

No compile and test errors on my machine, but I haven't test it against real elastic search servers. Publish it here to check out the community's opinions and the possibility of merging onto master. :)

Relevant tickets: #2240, #1982

Related PR: #2260

kylebrandt · 2018-09-24T16:34:20Z

Quick tests against v5 seem to behave correctly.

kylebrandt · 2018-09-24T16:39:18Z

Hmmm... I seem to be getting:

$ go run main.go -q -r -skiplast -dev  -n -w
2018/09/24 12:36:56 info: migrate.go:79: checking migrations
panic: interface conversion: interface {} is nil, not []elastic.ClientOptionFunc

goroutine 1 [running]:
main.main()
	/home/kbrandt/src/bosun.org/cmd/bosun/main.go:169 +0x18fe
exit status 2

That just me? Did not get that on the previous PR.

Edit: Seems to happen when I enable the AnnotateConf - maybe that was the case in the previous one as well.

bom-d-van · 2018-09-24T19:03:11Z

@kylebrandt Sorry, it was actually a bug in conf/system_elastic*.go files. I have pushed a fix: fdf3940

Commits in this PR have been reset too.

kylebrandt · 2018-09-24T19:47:14Z

Can you reword the first commit to something like:

cmd/bosun: BREAKING-CHANGE: support multiple elasticsearch versions at runtime
- Elastic configuration in the system configuration now *requires* that Version be specified or will fail to start.
- bump version to 0.8.0
- ...whatever else you want to say...

Then rebase and merge time :-)

…t runtime - Elastic configuration in the system configuration now *requires* that Version be specified or will fail to start. - Bump version to 0.8.0. - Supported versions are: 2.x, 5.x, 6.x.

For supporting multiple versions of elasticsearch at runtime.

bom-d-van · 2018-09-25T09:41:21Z

@kylebrandt Thanks, the new message is better. I tweak it a little bit. Hope that's ok.

kylebrandt · 2018-09-25T13:38:38Z

Getting panics on this, not quite sure what it is yet ... "reflect: call with two few arguments" ... I wonder if maybe it is something to do with the prefix but not sure yet

pradeepbbl · 2018-09-25T13:47:04Z

I will have a look at the prefix key..

kylebrandt · 2018-09-25T14:00:01Z

So far I am also only able to trigger it when running my alerts on a schedule, and not via the Rule Editor page. I'm not sure if that is the a difference between the two, or if I just have not found the particular alert causing the panic yet.

…

On Tue, Sep 25, 2018 at 9:48 AM, Pradeep Mishra ***@***.***> wrote: I will have a look at the prefix key.. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2316 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABnT0HUd3IanmqMgiip8zNfyWwEcW-Kaks5uejQkgaJpZM4W270x> .

bom-d-van · 2018-09-25T14:23:55Z

@kylebrandt is there any stack trace? Not really sure what's going on.

kylebrandt · 2018-09-25T14:27:16Z

panic: reflect: Call with too few input arguments [recovered]
	panic: reflect: Call with too few input arguments

goroutine 951 [running]:
bosun.org/cmd/bosun/expr.errRecover(0xc0012e9e80)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:144 +0x1b7
panic(0x105da60, 0x1607c40)
	/usr/local/go/src/runtime/panic.go:513 +0x1b9
reflect.Value.call(0x10d47e0, 0x1517b70, 0x13, 0x129d8c7, 0x4, 0xc0012e9058, 0x1, 0x1, 0xc00081e901, 0x10e0720, ...)
	/usr/local/go/src/reflect/value.go:364 +0x152f
reflect.Value.Call(0x10d47e0, 0x1517b70, 0x13, 0xc0012e9058, 0x1, 0x1, 0x0, 0x0, 0x2)
	/usr/local/go/src/reflect/value.go:308 +0xa4
bosun.org/cmd/bosun/expr.(*State).walkFunc.func1(0x1616840, 0xc000e74a20)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:779 +0xe70
bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler.(*Profile).Step(0xc000e74a20, 0xc000a5e6e0, 0xb, 0xc0005726e0)
	/home/kbrandt/src/bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler/types.go:195 +0x76
bosun.org/cmd/bosun/expr.(*State).walkFunc(0xc000e74990, 0xc000a1ec30, 0x1)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:731 +0xff
bosun.org/cmd/bosun/expr.(*State).walkFunc.func1(0x1616840, 0xc000e74a20)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:741 +0x11d7
bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler.(*Profile).Step(0xc000e74a20, 0xc000a5e6c0, 0xd, 0xc0005725c0)
	/home/kbrandt/src/bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler/types.go:195 +0x76
bosun.org/cmd/bosun/expr.(*State).walkFunc(0xc000e74990, 0xc000a1eb90, 0x0)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:731 +0xff
bosun.org/cmd/bosun/expr.(*State).walkFunc.func1(0x1616840, 0xc000e74a20)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:741 +0x11d7
bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler.(*Profile).Step(0xc000e74a20, 0xc000a5e6b0, 0x9, 0xc000572580)
	/home/kbrandt/src/bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler/types.go:195 +0x76
bosun.org/cmd/bosun/expr.(*State).walkFunc(0xc000e74990, 0xc000a1eb40, 0x0)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:731 +0xff
bosun.org/cmd/bosun/expr.(*State).walkFunc.func1(0x1616840, 0xc000e74a20)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:741 +0x11d7
bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler.(*Profile).Step(0xc000e74a20, 0xc000a5e6a8, 0x8, 0xc000572500)
	/home/kbrandt/src/bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler/types.go:195 +0x76
bosun.org/cmd/bosun/expr.(*State).walkFunc(0xc000e74990, 0xc000a1eaf0, 0xc000a5e681)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:731 +0xff
bosun.org/cmd/bosun/expr.(*State).walk(0xc000e74990, 0x1617c20, 0xc000a1eaf0, 0xc0011edae0)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:483 +0x13f
bosun.org/cmd/bosun/expr.(*State).walkBinary(0xc000e74990, 0xc0009f3f80, 0xc0000ba030)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:505 +0x5a
bosun.org/cmd/bosun/expr.(*State).walk(0xc000e74990, 0x1617b60, 0xc0009f3f80, 0x1)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:479 +0x3ed
bosun.org/cmd/bosun/expr.(*State).walkBinary(0xc000e74990, 0xc000a80000, 0x0)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:505 +0x5a
bosun.org/cmd/bosun/expr.(*State).walk(0xc000e74990, 0x1617b60, 0xc000a80000, 0x160e)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:479 +0x3ed
bosun.org/cmd/bosun/expr.(*State).walkBinary(0xc000e74990, 0xc000a80300, 0x40d7df)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:505 +0x5a
bosun.org/cmd/bosun/expr.(*State).walk(0xc000e74990, 0x1617b60, 0xc000a80300, 0x0)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:479 +0x3ed
bosun.org/cmd/bosun/expr.(*Expr).ExecuteState.func1(0x1616840, 0xc000e74a20)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:125 +0x4c
bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler.(*Profile).Step(0xc000e74a20, 0x12a6350, 0xc, 0xc0005724c0)
	/home/kbrandt/src/bosun.org/vendor/github.com/MiniProfiler/go/miniprofiler/types.go:195 +0x76
bosun.org/cmd/bosun/expr.(*Expr).ExecuteState(0xc000326bf0, 0xc000e74990, 0xc000566690, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:124 +0x10e
bosun.org/cmd/bosun/expr.(*Expr).Execute(0xc000326bf0, 0xc000333ee0, 0xc000e87e00, 0x0, 0x0, 0x2e981d78, 0xed33c3c98, 0x0, 0x0, 0x458800, ...)
	/home/kbrandt/src/bosun.org/cmd/bosun/expr/expr.go:114 +0xe7
bosun.org/cmd/bosun/sched.(*Schedule).executeExpr(0x20076a0, 0x0, 0x0, 0xc000ebcfc0, 0xc00071c7e0, 0xc000326bf0, 0x0, 0x0, 0x0)
	/home/kbrandt/src/bosun.org/cmd/bosun/sched/check.go:646 +0x177
bosun.org/cmd/bosun/sched.(*Schedule).CheckExpr.func2(0x20076a0, 0x0, 0x0, 0xc000ebcfc0, 0xc00071c7e0, 0xc000326bf0, 0xc00130e1e0)
	/home/kbrandt/src/bosun.org/cmd/bosun/sched/check.go:669 +0x6d
created by bosun.org/cmd/bosun/sched.(*Schedule).CheckExpr
	/home/kbrandt/src/bosun.org/cmd/bosun/sched/check.go:668 +0x135
exit status 2

pradeepbbl · 2018-09-25T14:33:32Z

@kylebrandt same here did run a couple of esquery from expression editor (with and without prefix) not able to reproduce this issue. I will run a test instance tomorrow and will update you in case of issue.

-Thanks

kylebrandt · 2018-09-25T15:10:45Z

got it.... will push to master

kylebrandt · 2018-09-25T15:20:51Z

Panic fixed in d400f79 , just a left over argument from the miniprofiler refactor (when it was moved the the State object)

bom-d-van · 2018-09-25T15:27:50Z

@kylebrandt Sorry for that. I relied on go build for the miniprofiler refactor that's why it wasn't caught. Thanks.

kylebrandt · 2018-09-25T15:29:24Z

@bom-d-van No apologies needed! Really appreciate your work here, this will make ES upgrade path so much better for many people, including at my company :P

bom-d-van force-pushed the multi-es-spt branch from a9aa1f4 to fc03c9d Compare September 24, 2018 15:52

bom-d-van changed the title ~~Support connecting to multiple versions elasticsearch at runtime [Beautified version of PR 2260]~~ Support connecting to multiple versions elasticsearch at runtime [beautified version of PR 2260] Sep 24, 2018

bom-d-van force-pushed the multi-es-spt branch from fc03c9d to 2aed2ee Compare September 24, 2018 19:01

bom-d-van force-pushed the multi-es-spt branch from 2aed2ee to 0400704 Compare September 25, 2018 06:25

bom-d-van added 2 commits September 25, 2018 08:27

cmd/bosun: BREAKING-CHANGE: support multiple elasticsearch versions a…

7ab982f

…t runtime - Elastic configuration in the system configuration now *requires* that Version be specified or will fail to start. - Bump version to 0.8.0. - Supported versions are: 2.x, 5.x, 6.x.

Vendor github.com/olivere/elastic and github.com/mailru/easyjson

6aec5dd

For supporting multiple versions of elasticsearch at runtime.

bom-d-van force-pushed the multi-es-spt branch from 0400704 to 6aec5dd Compare September 25, 2018 06:28

kylebrandt merged commit a40db73 into bosun-monitor:master Sep 25, 2018

kylebrandt mentioned this pull request Jan 14, 2019

Support connecting to multiple versions elasticsearch at runtime #2260

Closed

Uh oh!

Conversation

bom-d-van commented Sep 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kylebrandt commented Sep 24, 2018

Uh oh!

kylebrandt commented Sep 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bom-d-van commented Sep 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kylebrandt commented Sep 24, 2018

Uh oh!

bom-d-van commented Sep 25, 2018

Uh oh!

kylebrandt commented Sep 25, 2018

Uh oh!

pradeepbbl commented Sep 25, 2018

Uh oh!

kylebrandt commented Sep 25, 2018 via email

Uh oh!

bom-d-van commented Sep 25, 2018

Uh oh!

kylebrandt commented Sep 25, 2018

Uh oh!

pradeepbbl commented Sep 25, 2018

Uh oh!

kylebrandt commented Sep 25, 2018

Uh oh!

kylebrandt commented Sep 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bom-d-van commented Sep 25, 2018

Uh oh!

kylebrandt commented Sep 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bom-d-van commented Sep 24, 2018 •

edited

Loading

kylebrandt commented Sep 24, 2018 •

edited

Loading

bom-d-van commented Sep 24, 2018 •

edited

Loading

kylebrandt commented Sep 25, 2018 •

edited

Loading