Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratelimit on /api/count returns wrong bot ID in production #16

Open
MattIPv4 opened this issue Oct 6, 2019 · 0 comments

Comments

@MattIPv4
Copy link
Member

commented Oct 6, 2019

Bug Report

Description

This bug is only reproducible in the production test suite.

When making multiple valid requests in quick succession to the /api/count endpoint, the ratelimit response is returned as expected.

However, the bot id contained within that response does not match the bot id the request was sent as.

I really have no idea where this failure is coming from, it might be the app itself, but I would expect to then be able to reproduce this in staging or development -- perhaps its related to the load on the site. This could also be some form of caching issue, though Cloudflare is set to never cache API requests and IIS should not be caching anything at all.

Steps to reproduce

  1. Be a moderator logged into the production site
  2. Run the test suite at /test
  3. Observe test failure

image

Expected behavior

The ratelimit response should have the correct bot id.

Logs or Screenshots

See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.