Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions to test PRs #17

Closed
MattIPv4 opened this issue Oct 6, 2019 · 0 comments

Comments

@MattIPv4
Copy link
Member

commented Oct 6, 2019

Website/API Suggestion

Description

All PRs that are submitted to the repo should make use of GitHub Actions to run the test suite.

Things to consider:

  • This will need to generate its own config.js
    • Don't want to give it Discord details
    • Will need its own DB details
  • This will need its own DB
    • SQLite may be the simplest solution, but it will need to create this with a blank schema before migrations & seed

Why

Whilst most developers will test their code locally before PR'ing, having CI to ensure tests pass on PRs will be useful for reviewers.

@MattIPv4 MattIPv4 self-assigned this Oct 6, 2019
@MattIPv4 MattIPv4 added the enhancement label Oct 6, 2019
@MattIPv4 MattIPv4 closed this Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.