Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/tasks for mods&admins #20

Merged
merged 10 commits into from Oct 13, 2019

Conversation

@drdrjojo
Copy link
Contributor

commented Oct 8, 2019

Could be useful for #15 and future implemented jobs

@MattIPv4 MattIPv4 self-requested a review Oct 8, 2019
@MattIPv4

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

I'll do a proper review of this tomorrow but here's an initial thing:

Mods viewing tasks is fine, but can we restrict any actions (running, cancelling etc) to admin, please?

src/Dynamic/tasks.pug Outdated Show resolved Hide resolved
src/Dynamic/Includes/cards/taskcard.pug Outdated Show resolved Hide resolved
src/Assets/js/tasks.js Outdated Show resolved Hide resolved
src/Dynamic/Includes/cards/taskcard.pug Outdated Show resolved Hide resolved
src/Routes/Tasks.js Outdated Show resolved Hide resolved
@MattIPv4

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

This also needs updating to the latest node.

drdrjojo and others added 4 commits Oct 9, 2019
Add .editorconfig (#24)
@MattIPv4 MattIPv4 self-requested a review Oct 11, 2019
Copy link
Member

left a comment

Please resolve the ESLint issues.
The unused var issue can mitigated by using // eslint-disable-next-line no-unused-vars on the line before the function name (see https://github.com/botblock/BotBlock.org/blob/node/src/Assets/js/test.js#L17)

drdrjojo added 2 commits Oct 12, 2019
@drdrjojo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2019

It should include all requested changes and eslint fixes, ready for review!

src/Dynamic/Includes/cards/taskcard.pug Outdated Show resolved Hide resolved
src/Dynamic/Includes/tasks.pug Outdated Show resolved Hide resolved
src/Dynamic/tasks.pug Show resolved Hide resolved
src/Routes/Tasks.js Outdated Show resolved Hide resolved
src/Routes/Tasks.js Outdated Show resolved Hide resolved
src/Routes/Tasks.js Outdated Show resolved Hide resolved
src/Routes/Tasks.js Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 requested review from MattIPv4 and DetectiveHuman Oct 12, 2019
Copy link
Contributor

left a comment

Looks good to me.

Copy link
Member

left a comment

Lgtm.

@MattIPv4 MattIPv4 merged commit e549976 into botblock:node Oct 13, 2019
2 checks passed
2 checks passed
build
Details
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.