Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint config & test #25

Merged
merged 5 commits into from Oct 9, 2019

Conversation

@VivekSingh777
Copy link
Contributor

commented Oct 8, 2019

No description provided.

@VivekSingh777

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

@MattIPv4 Added eslint support

Copy link
Member

left a comment

  1. Indentation in the config file is inconsistent.
  2. Can we use strings for off/warn/error instead of their integer counterparts?
  3. Can eslint also be integrated into the mocha test suite, please?
@VivekSingh777

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

Screenshot 2019-10-09 at 4 10 06 AM
@MattIPv4 Did I need to fix all lint errors?

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

No, don’t worry about fixing the errors, that can be a separate issue once this is merged — However, is there a config change that can be made to resolve window & document being undefined being treated as an issue?

@VivekSingh777

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

No, don’t worry about fixing the errors, that can be a separate issue once this is merged — However, is there a config change that can be made to resolve window & document being undefined being treated as an issue?

  1. Indentation in the config file is inconsistent.
  2. Can we use strings for off/warn/error instead of their integer counterparts?
  3. Can eslint also be integrated into the mocha test suite, please?

@MattIPv4 Done

@VivekSingh777

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

@MattIPv4 Done changes and integrated eslint to mocha

@VivekSingh777 VivekSingh777 requested a review from MattIPv4 Oct 8, 2019
@MattIPv4

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

If this was integrated into the mocha test suite, should the CI have failed as there are outstanding eslint issues with the project?

@MattIPv4 MattIPv4 closed this Oct 8, 2019
@MattIPv4

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Oops.

@MattIPv4 MattIPv4 reopened this Oct 8, 2019
@VivekSingh777

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

If this was integrated into the mocha test suite, should the CI have failed as there are outstanding eslint issues with the project?

I don't get it?

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

The CI runs npm test which is the full mocha test suite, located in the /test directory. The eslint checks should be added so that they run as part of the mocha test suite, please :)

I can help with this in the morning if you’re stuck or unsure.

@VivekSingh777

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

Cool will take this up in morning.

@VivekSingh777

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

The CI runs npm test which is the full mocha test suite, located in the /test directory. The eslint checks should be added so that they run as part of the mocha test suite, please :)

I can help with this in the morning if you’re stuck or unsure.

Can u help me about your comment.
I have integrated eslint with mocha. Here is the screenshot for the same.
Screenshot 2019-10-09 at 11 32 35 AM
@MattIPv4

@MattIPv4 MattIPv4 force-pushed the VivekSingh777:21/add-eslint-to-project branch from 3fc5939 to 32b1648 Oct 9, 2019
@MattIPv4 MattIPv4 changed the base branch from node to eslint Oct 9, 2019
@MattIPv4 MattIPv4 changed the base branch from eslint to node Oct 9, 2019
@MattIPv4 MattIPv4 changed the base branch from node to eslint Oct 9, 2019
@MattIPv4 MattIPv4 changed the title #21 Added eslint Add eslint config & test Oct 9, 2019
@MattIPv4

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

CI failure expected.

Copy link
Member

left a comment

Lgtm.

@MattIPv4 MattIPv4 merged commit 2021b1c into botblock:eslint Oct 9, 2019
1 of 2 checks passed
1 of 2 checks passed
build
Details
WIP Ready for review
Details
MattIPv4 added a commit that referenced this pull request Oct 11, 2019
* added eslint

* Added eslint for mocha and changed to string rule

* ESLint mocha test

* Update ruleset

* Update ruleset
MattIPv4 added a commit that referenced this pull request Oct 12, 2019
* added eslint

* Added eslint for mocha and changed to string rule

* ESLint mocha test

* Update ruleset

* Update ruleset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.