Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement util for getting a list #61

Merged
merged 9 commits into from Jan 12, 2020
Merged

Implement util for getting a list #61

merged 9 commits into from Jan 12, 2020

Conversation

@MattIPv4
Copy link
Member

MattIPv4 commented Jan 5, 2020

  • Creates a new util to get a list. This handles legacy list id conversions as well as fetching all the features for the list.
  • Implements the list util in all existing code that fetches list data.
  • Updates the api/lists endpoint to return the full list data for each list unless filtered.
  • Implement new api/lists/:id endpoint that returns the full list data for a specific list id.
@MattIPv4 MattIPv4 self-assigned this Jan 5, 2020
MattIPv4 added 2 commits Jan 5, 2020
@MattIPv4

This comment has been minimized.

Copy link
Member Author

MattIPv4 commented Jan 5, 2020

Pushed this to stage. TIL stage/prod use Node 10. Object.fromEntries is Node 12. Plesk doesn't seem to have an option to use Node 12, will go scream at some people there.

@MattIPv4

This comment has been minimized.

Copy link
Member Author

MattIPv4 commented Jan 12, 2020

Tested on staging, is now working.

@MattIPv4 MattIPv4 requested a review from DetectiveHuman Jan 12, 2020
Copy link
Contributor

DetectiveHuman left a comment

All seems good

@MattIPv4 MattIPv4 merged commit aa7ad82 into node Jan 12, 2020
2 checks passed
2 checks passed
build
Details
WIP Ready for review
Details
@MattIPv4 MattIPv4 deleted the MattIPv4/get-list-util branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.