Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add best practices to website #65

Open
wants to merge 7 commits into
base: node
from
Open

Add best practices to website #65

wants to merge 7 commits into from

Conversation

@DetectiveHuman
Copy link
Contributor

DetectiveHuman commented Jan 14, 2020

Based off #58

@DetectiveHuman DetectiveHuman requested a review from MattIPv4 Jan 14, 2020
src/Jobs/BestPracticesUpdater.js Outdated Show resolved Hide resolved
src/Routes/Lists.js Outdated Show resolved Hide resolved
src/Routes/Lists.js Outdated Show resolved Hide resolved
@DetectiveHuman DetectiveHuman requested a review from MattIPv4 Jan 15, 2020
@@ -0,0 +1,12 @@

This comment has been minimized.

Copy link
@MattIPv4

MattIPv4 Jan 17, 2020

Member

Extra linebreak here that shouldn't be?

.hero
.hero-body.has-text-centered
h1.title.is-size-1 Best Practices for Discord Bot Lists
h4.title.is-size-4.is-primary Bot lists must meet these minimum requirements to be considered a bot list.

This comment has been minimized.

Copy link
@MattIPv4

MattIPv4 Jan 17, 2020

Member

This subtitle is included in the doc itself, feels repetitive?

});
res.render('lists/best_practices', {
title: 'Best Practices for Discord Bot Lists',
data: this.renderer.render(bestPractices[0].value)

This comment has been minimized.

Copy link
@MattIPv4

MattIPv4 Jan 17, 2020

Member

Could we some logic to drop the h1 title from the MD, as it's already rendered in the page itself?

const BaseJob = require('../Structure/BaseJob');
const axios = require('axios');

class BestPracticesUpdater extends BaseJob {

This comment has been minimized.

Copy link
@MattIPv4

MattIPv4 Jan 17, 2020

Member

This job should run during the application start. We should create a new Initializers directory. The migrations check can move to a file there (throw an error if migrations are needed, so it aborts the app boot) & running this job can also be a script in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.