Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two separate lists for must-haves & should-haves #7

merged 3 commits into from Aug 18, 2019


Copy link

commented Aug 11, 2019

This pull request intends to close #1

Implement two separate lists, with the first containing what we consider to be bare-minimum must-have requirements for any bot list. The second list contains what would be considered best practices that are should-haves for lists but not absolute requirements.

@MattIPv4 MattIPv4 self-assigned this Aug 11, 2019


This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2019

Feedback would be appreciated for any further changes before final review & merge.

@Habchy Habchy marked this pull request as ready for review Aug 13, 2019

Copy link

left a comment

i approve we should definitely split these up, but there seems to be complications now because of other changes

@MattIPv4 MattIPv4 requested review from Habchy and Andre601 Aug 13, 2019

Copy link

left a comment

There are some minor things that imo should have some changes Outdated Show resolved Hide resolved Show resolved Hide resolved Outdated Show resolved Hide resolved Outdated Show resolved Hide resolved

@MattIPv4 MattIPv4 requested a review from Andre601 Aug 17, 2019

@MattIPv4 MattIPv4 merged commit c9bf3b2 into master Aug 18, 2019

@MattIPv4 MattIPv4 deleted the MattIPv4/must-should branch Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.