Enhancement/108/add retry on poll #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix to getting throttled by the SWF API. _complete should already retry (thrice, is this enough?) Signed-off-by: Yves Bastide <yves@botify.com>
These methods are not much private: let's rename them to *_with_retry. Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
jbbarth
reviewed
Feb 3, 2017
Collaborator
jbbarth
left a comment
jbbarth
left a comment
There was a problem hiding this comment.
I think it's greaaat!! 👍
We can only add the same thing on poller.fail() which sometimes break.
Totally untested! Signed-off-by: Yves Bastide <yves@botify.com>
Contributor
Author
|
Done, without even launching the tests locally 🙂 |
Collaborator
|
Ready to merge? |
Contributor
Author
|
Ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retry on polling on ResponseError (e.g. throttling): what do you think @jbbarth?