From 075634f49441ff293e1717d44c04862b257f65c6 Mon Sep 17 00:00:00 2001 From: Jack Bruno Date: Mon, 31 Mar 2014 23:54:31 -0600 Subject: [PATCH 1/2] Adding missing health_check value for weighted record sets. --- boto/route53/record.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boto/route53/record.py b/boto/route53/record.py index 87359b167b..3449c625d4 100644 --- a/boto/route53/record.py +++ b/boto/route53/record.py @@ -346,6 +346,8 @@ def endElement(self, name, value, connection): self.weight = value elif name == 'Region': self.region = value + elif name == 'HealthCheckId': + self.health_check = value def startElement(self, name, attrs, connection): return None From bf24406266499193d7a445c9e8ed8b4a26848daa Mon Sep 17 00:00:00 2001 From: Jack Bruno Date: Thu, 24 Apr 2014 23:47:12 -0600 Subject: [PATCH 2/2] Add test case check for setting healthcheck property on resource record. --- tests/unit/route53/test_connection.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/unit/route53/test_connection.py b/tests/unit/route53/test_connection.py index 5859be43ae..6bcbfe8a4a 100644 --- a/tests/unit/route53/test_connection.py +++ b/tests/unit/route53/test_connection.py @@ -272,6 +272,7 @@ def default_body(self): true example-123456-evaluate-health.us-west-2.elb.amazonaws.com. + abcdefgh-abcd-abcd-abcd-abcdefghijkl us-west-2-no-evaluate-health.example.com. @@ -283,6 +284,7 @@ def default_body(self): false example-123456-no-evaluate-health.us-west-2.elb.amazonaws.com. + abcdefgh-abcd-abcd-abcd-abcdefghijkl false @@ -314,6 +316,7 @@ def test_get_all_rr_sets(self): self.assertTrue(evaluate_record.alias_evaluate_target_health) self.assertEqual(evaluate_record.alias_dns_name, 'example-123456-evaluate-health.us-west-2.elb.amazonaws.com.') evaluate_xml = evaluate_record.to_xml() + self.assertTrue(evaluate_record.health_check, 'abcdefgh-abcd-abcd-abcd-abcdefghijkl') self.assertTrue('true' in evaluate_xml) no_evaluate_record = response[3] @@ -325,4 +328,5 @@ def test_get_all_rr_sets(self): self.assertFalse(no_evaluate_record.alias_evaluate_target_health) self.assertEqual(no_evaluate_record.alias_dns_name, 'example-123456-no-evaluate-health.us-west-2.elb.amazonaws.com.') no_evaluate_xml = no_evaluate_record.to_xml() + self.assertTrue(no_evaluate_record.health_check, 'abcdefgh-abcd-abcd-abcd-abcdefghijkl') self.assertTrue('false' in no_evaluate_xml)