Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VPC tenancy restrictions and filters for DHCP options #1801

Merged
merged 5 commits into from Oct 23, 2013

Conversation

mbarrien
Copy link
Contributor

This pull request adds support for 2 VPC related features that aren't currently exposed by Boto:

@danielgtaylor
Copy link
Member

This looks great, however can you please add a unit test for the new parameters here? https://github.com/boto/boto/blob/develop/tests/unit/vpc/test_vpc.py

@mbarrien
Copy link
Contributor Author

May take a while for me... this is my first time in Boto code and Boto's test framework. Keep in mind no existing unit test code exists at all for either of the 2 affected methods (or for most of the vpc module) in its current state before these modifications.

@mbarrien
Copy link
Contributor Author

Added unit tests for new parameters (aka created unit tests for the first time for the functions). While I was in there, converted existing tests that used duck-typing to use the seemingly more official AWSMockServiceTestCase.

Please re-review and consider for merging.

@ghost ghost assigned danielgtaylor Oct 23, 2013
@danielgtaylor
Copy link
Member

This looks great! Thanks for writing the tests 👍

danielgtaylor added a commit that referenced this pull request Oct 23, 2013
Support VPC tenancy restrictions and filters for DHCP options. Fixes #1801.
@danielgtaylor danielgtaylor merged commit 8c5d8de into boto:develop Oct 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants