Add method TaggedEC2Object.add_tags(). #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already a TaggedEC2Object.add_tag() method but it only supports adding one tag at a time. The CreateTags api supports adding multiple tags at once. So, when you want to add multiple tags you needlessly make multiple round-trips to EC2 service. The add_tags method helps in avoiding that.
|
This looks good. Would it be possible to get some unit tests on this? Unfortunately, there are no existing tests ( |
The documentation says that there is a distinction between a
value of '' and a value of None. The API docs say the same
thing. But the code was not following the docs:
if value:
returns False for both None and ''.
|
I have added unit tests for all methods in |
|
Thanks for adding the tests. 👍 |
danielgtaylor
added a commit
that referenced
this pull request
Jun 6, 2014
Add method TaggedEC2Object.add_tags(). Fixes #2259.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a
TaggedEC2Object.add_tag()method but it only supportsadding one tag at a time. The CreateTags api supports adding multiple tags
at once. So, when you want to add multiple tags you needlessly make multiple
round-trips to EC2 service. The
add_tags()method helps in avoiding that.