Glacier: Added a get_output_chunk method that gets a chunk of job output and checks its hash #1000

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

almost commented Sep 19, 2012

No description provided.

Owner

jamesls commented Nov 14, 2012

The Job class has a download_to_file which abstracts the whole process of downloading chunks. I'm trying to think of a use case where get_output_chunk would be preferred to download_to_file.

I'll also like moving the tree hash calculations off to a separate utils module. I'll go ahead and file a separate issue so we can track that separately.

Contributor

almost commented Nov 14, 2012

If you're streaming to elsewhere then it's useful to be able to grab chunks one by one and to be able to re-get a chunk if it fails.

Owner

jamesls commented Nov 14, 2012

Ok, there seems like there's probably some similar code that could be shared between download_to_file and get_output_chunk. I'll try to refactor this.

@ghost ghost assigned jamesls Nov 14, 2012

@jamesls jamesls closed this in 30c64ab Jan 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment