New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tagged RDS DBInstances #1050

Closed
wants to merge 5 commits into
base: develop
from

Conversation

Projects
None yet
1 participant
@gertjanol
Contributor

gertjanol commented Oct 12, 2012

These commits add support for listing, creating and removing tags to and from RDS-DBInstances (ListTagsForResource, AddTagsToResource and RemoveTagsFromResource API calls).

Amazon requires an ARN to reference the DBInstance on which the actions are performed, but doesn't supply this ARN, afaik. I added a property to the DBInstance-class, which uses IAM (for the account-id) to construct the ARN itself when asked for. It's not very clean, but I didn't see another way. If Amazon does supply the ARN in another way, or in the future, this could easily be removed while retaining backwards compatibility.

I'm hoping to add support for a TaggedRDSResource, similar to the TaggedEC2Resource.

I welcome your thought and suggestions!

@gertjanol

This comment has been minimized.

Show comment
Hide comment
@gertjanol

gertjanol Oct 15, 2012

Contributor

Created a new pullrequest with the same commits, but in it's own featurebranch (#1061)

Contributor

gertjanol commented Oct 15, 2012

Created a new pullrequest with the same commits, but in it's own featurebranch (#1061)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment