Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for #1019 / rework of request building logic. #1058

Merged
merged 1 commit into from Nov 14, 2012

Conversation

Projects
None yet
2 participants
Contributor

oozie commented Oct 15, 2012

This change provides the fix for #1019 through rework of JSON request creation.

TESTING

  • pylint,
  • smoke tests
    • confirmed expected behaviour through method calls, and
    • running workflows with libraries dependent on this code,
    • running the code sample from #1021

As a positive side effect readability of the code improved and each method exposes a dictionary structure identical to JSON going into a request.

Special attention has been payed to backwards compatibility: no code should break (except for one that relies on buggy behaviour; such code is unlikely to exist, though, and will have to break at some point anyway).

@garnaat garnaat merged commit 7d5615a into boto:develop Nov 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment