use ElementList instead of Element for boto.mws.response.GetReportReques... #1067

Merged
merged 1 commit into from Oct 19, 2012

Conversation

Projects
None yet
3 participants
@isaacbowen
Contributor

isaacbowen commented Oct 18, 2012

...tListResult.ReportRequestInfo

The GetReportRequestList response can contain multiple ReportRequestInfo elements, and using Element for these results in the loss of all but final element.

@disruptek

This comment has been minimized.

Show comment Hide comment
@disruptek

disruptek Oct 18, 2012

Contributor

Thanks, but this is already fixed in develop.

Contributor

disruptek commented Oct 18, 2012

Thanks, but this is already fixed in develop.

@isaacbowen

This comment has been minimized.

Show comment Hide comment
@isaacbowen

isaacbowen Oct 18, 2012

Contributor

Awesome, thank you.

Contributor

isaacbowen commented Oct 18, 2012

Awesome, thank you.

@isaacbowen isaacbowen closed this Oct 18, 2012

@isaacbowen

This comment has been minimized.

Show comment Hide comment
@isaacbowen

isaacbowen Oct 18, 2012

Contributor

Ah, actually, I see that this has been fixed for GetReportListResult.ReportInfo in 293ae43, but it doesn't look like the same fix was applied for GetReportRequestList.ReportRequestInfo.

Contributor

isaacbowen commented Oct 18, 2012

Ah, actually, I see that this has been fixed for GetReportListResult.ReportInfo in 293ae43, but it doesn't look like the same fix was applied for GetReportRequestList.ReportRequestInfo.

@isaacbowen isaacbowen reopened this Oct 18, 2012

@disruptek

This comment has been minimized.

Show comment Hide comment
@disruptek

disruptek Oct 18, 2012

Contributor

You're right; that somehow escaped my commit. Thanks for the catch.

Contributor

disruptek commented Oct 18, 2012

You're right; that somehow escaped my commit. Thanks for the catch.

garnaat added a commit that referenced this pull request Oct 19, 2012

Merge pull request #1067 from Threadless/mws-report-request-info-list
use ElementList instead of Element for boto.mws.response.GetReportReques...

@garnaat garnaat merged commit f2412dd into boto:develop Oct 19, 2012

msabramo pushed a commit to msabramo/boto that referenced this pull request Nov 28, 2012

Merge pull request #1067 from Threadless/mws-report-request-info-list
use ElementList instead of Element for boto.mws.response.GetReportReques...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment