Fixups #1140

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

reversefold commented Nov 27, 2012

No description provided.

Owner

garnaat commented Dec 3, 2012

I'm getting a conflict on this PR now. Could you rebase and resubmit? Thanks.

Contributor

reversefold commented Dec 3, 2012

Rebased and pushed. In fixing the merge conflict I noticed there was a copy/paste error in the auth_region_name property declaration. This merge fixes that by replacing that with decorators.

Owner

jamesls commented Dec 10, 2012

I think the @foo.setter syntax is more concise than how it's currently done. However, even though boto "officially" supports >= 2.6, we do have 2.5 users, and given this is in boto.connection this would essentially break all 2.5 users (the setter attribute was added in 2.6). I'm inclined to keep the property definitions the way they are.

Thanks for the heads up on the auth_region_name though. I'll go ahead and fix that as a separate commit so your pull request can stay focused on a single issue.

Contributor

reversefold commented Dec 15, 2012

I see....I assumed that since the requirements said python 2.6 that I could use a 2.6 feature. I'll switch it back in my branch.

Contributor

reversefold commented Dec 15, 2012

Pull request updated. I've still changed 2 properties to @property but those should be fine with python 2.5 since there are no setters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment