Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removal of some unused imports and some minor fixes. #1198

Open
wants to merge 27 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

abhinav-upadhyay commented Dec 23, 2012

Apart from the large number of unused imports, the pull request also addresses two small errors I noticed in the code:

  1. At one place, the pass statement was not properly indented.
  2. Also, boto/emr/step.py had a bunch of methods trying to raise NotImplemented, which I believe, should have been raise NotImplementedError().
Contributor

abhinav-upadhyay commented Dec 25, 2012

Just to add, the recent commits fix a bunch of indentation errors in the integration tests. Also, I have added init.py in tests/unit/sts to resolve the import errors.

Owner

jamesls commented Jan 3, 2013

This is a really big pull request, and I think it would make sense to split it up into more logical changes.

Another area of concern is that while these imports aren't used in a particular module, they may be imported by other code. A valid way this might come up is maintaining backwards compatibility with objects that have been moved to other modules. For example, one of the removed imports in this pull request is from glacier, which has a comment directly above it saying why the import is kept:

# This import is provided for backwards compatibility.  This function is
# now in boto.glacier.utils, but any existing code can still import
# this directly from this module.
from boto.glacier.utils import compute_hashes_from_fileobj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment