Refactored GCS tests and added tests for GCS versioning feature. #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jterrace
commented
Dec 28, 2012
jterrace
commented
- Refactored the GCS-specific tests into their own module instead of living under the s3 integration module.
- Fixed misspelling of "harness".
- Added gs credential detection and unittest skip for all gs tests.
- Added tests for GCS versioning support.
- Fixed a few minor bugs that surfaced after writing versioning tests.
* Refactored gs tests into their own gs module. * Fixed misspelling of harness. * Added gs credential detection and unittest skip for all gs tests.
ghost
assigned …ng test comments.
|
Just pushed cf6ec35 which addresses your comments. PTAL |
mfschwartz
added a commit
that referenced
this pull request
Jan 2, 2013
Refactored GCS tests and added tests for GCS versioning feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.